stream: async iterator stop read if destroyed

Fixes some compatibility issues where it is expected that for await stops reading when the stream is destroyed. Refs: #34887 PR-URL: #35640 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 15, 2020 · 1d8ecd8 · 1d8ecd8
1 parent bfc9069
commit 1d8ecd8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -1095,7 +1095,7 @@ async function* createAsyncIterator(stream) {
 
   try {
     while (true) {
-      const chunk = stream.read();
+      const chunk = stream.destroyed ? null : stream.read();
       if (chunk !== null) {
         yield chunk;
       } else if (errorEmitted) {

diff --git a/test/parallel/test-stream-readable-async-iterators.js b/test/parallel/test-stream-readable-async-iterators.js
@@ -43,8 +43,6 @@ async function tests() {
     });
 
     const iter = Readable.prototype[Symbol.asyncIterator].call(stream);
-    await iter.next();
-    await iter.next();
     await iter.next()
       .then(common.mustNotCall())
       .catch(common.mustCall((err) => {