Skip to content

Commit

Permalink
tools: use {N} for spaces in regex
Browse files Browse the repository at this point in the history
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

PR-URL: #41295
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
Trott authored and targos committed Jan 14, 2022
1 parent d0d595f commit 1985284
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/find-inactive-collaborators.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const authors = await runGitCommand(
// Get all approving reviewers of landed commits during the time period.
const approvingReviewers = await runGitCommand(
`git log --since="${SINCE}" | egrep "^ Reviewed-By: "`,
(line) => /^ Reviewed-By: ([^<]+)/.exec(line)[1].trim()
(line) => /^ {4}Reviewed-By: ([^<]+)/.exec(line)[1].trim()
);

async function getCollaboratorsFromReadme() {
Expand All @@ -72,7 +72,7 @@ async function getCollaboratorsFromReadme() {
foundCollaboratorHeading = true;
}
if (line.startsWith(' **') && isCollaborator) {
const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const mailmap = await runGitCommand(
`git check-mailmap '${name} <${email}>'`
);
Expand Down Expand Up @@ -136,7 +136,7 @@ async function moveCollaboratorToEmeritus(peopleToMove) {
if (line.startsWith('* ')) {
collaboratorFirstLine = line;
} else if (line.startsWith(' **')) {
const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line);
if (peopleToMove.some((entry) => {
return entry.name === name && entry.email === email;
})) {
Expand Down

0 comments on commit 1985284

Please sign in to comment.