src: prefer param function check over args length

PR-URL: #23835 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
nodejs · Nov 13, 2018 · 17e80ec · 17e80ec
1 parent 415fcde
commit 17e80ec
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -418,7 +418,7 @@ function open(path, flags, mode, callback) {
     callback = flags;
     flags = 'r';
     mode = 0o666;
-  } else if (arguments.length === 3) {
+  } else if (typeof mode === 'function') {
     callback = mode;
     mode = 0o666;
   }
@@ -811,7 +811,7 @@ function readdirSync(path, options) {
 }
 
 function fstat(fd, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }
@@ -822,7 +822,7 @@ function fstat(fd, options, callback) {
 }
 
 function lstat(path, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }
@@ -835,7 +835,7 @@ function lstat(path, options, callback) {
 }
 
 function stat(path, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }