Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine du Hamel <[email protected]>
  • Loading branch information
pd4d10 and aduh95 authored May 16, 2021
1 parent fce76fe commit 1648190
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/_http_agent.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const { once } = require('internal/util');
const {
validateNumber,
validateOneOf,
validateString
validateString,
} = require('internal/validators');

const kOnKeylog = Symbol('onkeylog');
Expand Down
3 changes: 2 additions & 1 deletion lib/_tls_wrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,9 @@ function TLSSocket(socket, opts) {
process.emitWarning('Enabling --trace-tls can expose sensitive data in ' +
'the resulting log.');
}
} else
} else {
validateBoolean(enableTrace, 'options.enableTrace');
}

if (tlsOptions.ALPNProtocols)
tls.convertALPNProtocols(tlsOptions.ALPNProtocols, tlsOptions);
Expand Down
2 changes: 1 addition & 1 deletion lib/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ const {

const {
validateAbortSignal,
validateBoolean,
validateFunction,
validateBoolean
} = require('internal/validators');

const kCapture = Symbol('kCapture');
Expand Down

0 comments on commit 1648190

Please sign in to comment.