Skip to content

Commit

Permalink
deps: patch V8 to 11.3.244.8
Browse files Browse the repository at this point in the history
Refs: v8/v8@11.3.244.4...11.3.244.8
PR-URL: #47536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
  • Loading branch information
targos committed May 2, 2023
1 parent 8712eaf commit 13105c1
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 11
#define V8_MINOR_VERSION 3
#define V8_BUILD_NUMBER 244
#define V8_PATCH_LEVEL 4
#define V8_PATCH_LEVEL 8

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 2 additions & 0 deletions deps/v8/infra/mb/mb_config.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
# PGO
'V8 Linux PGO instrumentation - builder' : 'builtins_profiling_x86',
'V8 Linux64 PGO instrumentation - builder' : 'builtins_profiling_x64',
'V8 Win32 PGO instrumentation - builder' : 'builtins_profiling_x86',
'V8 Win64 PGO instrumentation - builder' : 'builtins_profiling_x64',

# Linux.
'V8 Linux - builder': 'release_x86_gcmole',
Expand Down
17 changes: 17 additions & 0 deletions deps/v8/infra/testing/builders.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1911,6 +1911,15 @@
{'name': 'v8testing', 'shards': 5},
],
},
'V8 Win32 PGO instrumentation - builder' : {
'swarming_dimensions': {
'cpu': 'x86-64',
'os': 'Windows-10-19045',
},
'tests': [
{'name': 'pgo_instrumentation'}
],
},
'V8 Win64': {
'swarming_dimensions': {
'os': 'Windows-10-19045',
Expand Down Expand Up @@ -1951,6 +1960,14 @@
{'name': 'v8testing', 'shards': 5},
],
},
'V8 Win64 PGO instrumentation - builder' : {
'swarming_dimensions': {
'os': 'Windows-10-19045',
},
'tests': [
{'name': 'pgo_instrumentation'}
],
},
##############################################################################
# Ports.
'V8 Android Arm64 - N5X': {
Expand Down
3 changes: 3 additions & 0 deletions deps/v8/src/builtins/builtins-error.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ BUILTIN(ErrorCaptureStackTrace) {
THROW_NEW_ERROR_RETURN_FAILURE(
isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj));
}
if (object_obj->IsJSGlobalProxy()) {
return ReadOnlyRoots(isolate).undefined_value();
}

Handle<JSObject> object = Handle<JSObject>::cast(object_obj);
Handle<Object> caller = args.atOrUndefined(isolate, 2);
Expand Down
3 changes: 2 additions & 1 deletion deps/v8/tools/builtins-pgo/profile_only.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def parse_arguments():
'the isolate aready contains the instrumented binary.'))
parser.add_argument(
'--v8-target-cpu',
default='pgo',
help='target cpu to build the profile for: x64 or arm64')
parser.add_argument(
'--benchmark_path',
Expand All @@ -33,7 +34,7 @@ def parse_arguments():
'--d8-path',
default=Path('./out/build/d8'),
help=('path to the d8 executable, by default `./out/build/d8` in '
'swarming context. Use together with `--profile-only`'),
'swarming context'),
type=Path)
parser.add_argument('--output-dir', type=Path)
return parser.parse_args()
Expand Down
2 changes: 2 additions & 0 deletions deps/v8/tools/whitespace.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ Today's answer to life the universe and everything is 6728!
Today's answer to life the universe and everything is 6728!!
Off-course, this is wrong ...
..
What's a fish without eyes? A fsh!

0 comments on commit 13105c1

Please sign in to comment.