Skip to content

Commit

Permalink
test: ensure test-npm-install uses correct node
Browse files Browse the repository at this point in the history
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: #6648

PR-URL: #6658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
Myles Borins authored and evanlucas committed May 17, 2016
1 parent bddf413 commit 0c62bd1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/parallel/test-npm-install.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ const pkgPath = path.join(common.tmpDir, 'package.json');
fs.writeFileSync(pkgPath, pkgContent);

const proc = spawn(process.execPath, args, {
cwd: common.tmpDir
cwd: common.tmpDir,
env: {
PATH: path.dirname(process.execPath)
}
});

function handleExit(code, signalCode) {
Expand Down

0 comments on commit 0c62bd1

Please sign in to comment.