crypto: improve randomBytes() performance

PR-URL: #31519 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Mar 15, 2020 · 087ad9c · 087ad9c
1 parent 4967bd0
commit 087ad9c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/benchmark/crypto/randomBytes.js b/benchmark/crypto/randomBytes.js
@@ -0,0 +1,16 @@
+'use strict';
+
+const common = require('../common.js');
+const { randomBytes } = require('crypto');
+
+const bench = common.createBenchmark(main, {
+  size: [64, 1024, 8192, 512 * 1024],
+  n: [1e3],
+});
+
+function main({ n, size }) {
+  bench.start();
+  for (let i = 0; i < n; ++i)
+    randomBytes(size);
+  bench.end(n);
+}
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -6,7 +6,7 @@ const {
 } = primordials;
 
 const { AsyncWrap, Providers } = internalBinding('async_wrap');
-const { Buffer, kMaxLength } = require('buffer');
+const { kMaxLength } = require('buffer');
 const { randomBytes: _randomBytes } = internalBinding('crypto');
 const {
   ERR_INVALID_ARG_TYPE,
@@ -15,6 +15,7 @@ const {
 } = require('internal/errors').codes;
 const { validateNumber } = require('internal/validators');
 const { isArrayBufferView } = require('internal/util/types');
+const { FastBuffer } = require('internal/buffer');
 
 const kMaxUint32 = 2 ** 32 - 1;
 const kMaxPossibleLength = MathMin(kMaxLength, kMaxUint32);
@@ -52,7 +53,7 @@ function randomBytes(size, cb) {
   if (cb !== undefined && typeof cb !== 'function')
     throw new ERR_INVALID_CALLBACK(cb);
 
-  const buf = Buffer.alloc(size);
+  const buf = new FastBuffer(size);
 
   if (!cb) return handleError(_randomBytes(buf, 0, size), buf);
 

diff --git a/test/benchmark/test-benchmark-crypto.js b/test/benchmark/test-benchmark-crypto.js
@@ -19,6 +19,7 @@ runBenchmark('crypto',
                'len=1',
                'n=1',
                'out=buffer',
+               'size=1',
                'type=buf',
                'v=crypto',
                'writes=1',