doc: add try/catch in http2 respondWithFile example

nodejs · Apr 26, 2021 · 05fa193 · 05fa193
1 parent ee9e2a2
commit 05fa193
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/doc/api/http2.md b/doc/api/http2.md
@@ -1669,10 +1669,17 @@ server.on('stream', (stream) => {
   }
 
   function onError(err) {
-    if (err.code === 'ENOENT') {
-      stream.respond({ ':status': 404 });
-    } else {
-      stream.respond({ ':status': 500 });
+    // stream.respond() can throw if the stream has been destroyed by
+    // the other side.
+    try {
+      if (err.code === 'ENOENT') {
+        stream.respond({ ':status': 404 });
+      } else {
+        stream.respond({ ':status': 500 });
+      }
+    } catch (err) {
+      // Perform actual error handling.
+      console.log(err);
     }
     stream.end();
   }