stream: fix pipeline with dest in objectMode

pipeline did not support destination with generator that does not return strings or buffers. PR-URL: #32414 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Mar 25, 2020 · 05f1df5 · 05f1df5
1 parent 9e3eddc
commit 05f1df5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js
@@ -240,7 +240,9 @@ function pipeline(...streams) {
         // always returns a stream which can be further
         // composed through `.pipe(stream)`.
 
-        const pt = new PassThrough();
+        const pt = new PassThrough({
+          objectMode: true
+        });
         if (isPromise(ret)) {
           ret
             .then((val) => {

diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -1065,3 +1065,15 @@ const { promisify } = require('util');
   src.push('asd');
   dst.destroy();
 }
+
+{
+  pipeline(async function * () {
+    yield 'asd';
+  }, async function * (source) {
+    for await (const chunk of source) {
+      yield { chunk };
+    }
+  }, common.mustCall((err) => {
+    assert.ifError(err);
+  }));
+}