apply suggestion

nodejs · Dec 20, 2022 · 021ad3d · 021ad3d
1 parent c3cea01
commit 021ad3d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -1,13 +1,14 @@
 'use strict';
 const {
   ArrayPrototypePush,
+  ObjectCreate,
   ObjectGetOwnPropertyDescriptor,
   SafePromiseAllReturnArrayLike,
   RegExp,
   RegExpPrototypeExec,
   SafeMap,
 } = primordials;
-const { basename, isAbsolute } = require('path');
+const { basename } = require('path');
 const { createWriteStream } = require('fs');
 const { createDeferredPromise } = require('internal/util');
 const { getOptionValue } = require('internal/options');
@@ -104,11 +105,16 @@ async function getReportersMap(reporters, destinations) {
     const destination = kBuiltinDestinations.get(destinations[i]) ?? createWriteStream(destinations[i]);
 
     // Load the test reporter passed to --test-reporter
-    const reporterPath = kBuiltinReporters.get(name) ?? name;
+    const reporterSpecifier = kBuiltinReporters.get(name) ?? name;
+    let parentURL;
+    try {
+      const { pathToFileURL } = require('internal/url');
+      parentURL = pathToFileURL(process.cwd() + '/').href;
+    } catch {
+      parentURL = 'file:///';
+    }
     const { esmLoader } = require('internal/process/esm_loader');
-    const { pathToFileURL } = require('internal/url');
-    const file = isAbsolute(reporterPath) ? pathToFileURL(reporterPath).href : reporterPath;
-    let reporter = await esmLoader.import(file, undefined, { __proto__: null });
+    let reporter = await esmLoader.import(reporterSpecifier, parentURL, ObjectCreate(null));
 
     if (reporter?.default) {
       reporter = reporter.default;

diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js
@@ -99,7 +99,8 @@ describe('node:test reporters', { concurrency: true }, () => {
                             { cwd: fixtures.path('test-runner') });
     assert.strictEqual(child.stderr.toString(), '');
     assert.strictEqual(child.stdout.toString(),
-                       'package: reporter-cjs{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
+                       'package: reporter-cjs' +
+                       '{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
   });
 
   it('should support a custom ESM reporter from node_modules', async () => {
@@ -108,6 +109,7 @@ describe('node:test reporters', { concurrency: true }, () => {
                             { cwd: fixtures.path('test-runner') });
     assert.strictEqual(child.stderr.toString(), '');
     assert.strictEqual(child.stdout.toString(),
-                       'package: reporter-esm{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
+                       'package: reporter-esm' +
+                       '{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
   });
 });