http: add callback is function check

We were checking that the callback existed, but not checking that it was a function. In `setTimeout`, if callback is truthy but not a function, throw a TypeError Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #3090
nodejs · Oct 6, 2015 · 0094a8d · 0094a8d
1 parent 05d424c
commit 0094a8d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -89,8 +89,12 @@ exports.OutgoingMessage = OutgoingMessage;
 
 
 OutgoingMessage.prototype.setTimeout = function(msecs, callback) {
-  if (callback)
+
+  if (callback) {
+    if (typeof callback !== 'function')
+      throw new TypeError('callback must be a function');
     this.on('timeout', callback);
+  }
 
   if (!this.socket) {
     this.once('socket', function(socket) {