Skip to content

tools: update v8.gyp #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richardlau wants to merge 1 commit into from
Closed

tools: update v8.gyp #136

richardlau wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Jan 17, 2020

Comma was missing in sources for torque_generated_initializers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@richardlau richardlau mentioned this pull request Jan 17, 2020
Closed
@targos
Copy link
Member

targos commented Jan 17, 2020

Thanks, and sorry for making this mistake. Pushed to canary-base.

@targos targos closed this Jan 17, 2020
@targos targos mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richardlau @targos @gengjiawen