Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

mdb_v8: fix cstyle nits #9205

Closed
wants to merge 1 commit into from

Conversation

davepacheco
Copy link

The illumos platform (which shares the same code) has stricter cstyle guidelines. These changes bring the canonical Node code in sync with illumos.

@brendanashworth
Copy link

This is change to a dependency, and all dependency patches must be upstreamed first before we accept them into core (this is a policy, not mine!). Thanks for putting the time into this, but I'm going to close this as I don't think we can accept it.

@davepacheco
Copy link
Author

This has been upstream in mdb_v8 for a while.

@davepacheco
Copy link
Author

That said, mdb_v8 itself has evolved quite a bit since the last sync, and we should probably resync the whole thing. @misterdjules has been doing a bunch of the recent work on this.

@brendanashworth
Copy link

Ah! If you wanted to float a specific patch you could, but you'd need to provide more info on the patch shas and stuff. Perhaps you could bring this up in nodejs/node#2517?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants