This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: enable small-icu support for build-release #9100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes nodejs#9099.
|
LGTM |
|
LGTM! |
misterdjules
pushed a commit
that referenced
this pull request
Jan 26, 2015
On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes #9099. PR: #9100 PR-URL: #9100 Reviewed-By: Steven R. Loomis <[email protected]> Reviewed-By: Timothy J Fontaine <[email protected]>
|
landed in e670732 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when building the "build-release" rule, enable both small-icu
and download-all.
This change also slightly refactors the build-release rule, mainly so that
it's easier to read.
The resulting MSI package was tested on Windows 7.
Fixes #9099.