Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

repl: make 'Unexpected token' errors recoverable #8875

Closed
wants to merge 1 commit into from

Conversation

misterdjules
Copy link

Fix the regexp used to detect 'Unexpected token' errors so that they can
be considered as recoverable. This fixes the following use case:

> var foo = 'bar \
... baz';
undefined
> foo
'bar baz'
>

Fixes #8874

@cjihrig
Copy link

cjihrig commented Dec 15, 2014

Seems simple enough. LGTM

@misterdjules misterdjules added this to the 0.12.1 milestone Dec 22, 2014
@misterdjules misterdjules modified the milestones: 0.12.3, 0.12.2 Apr 1, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can
be considered as recoverable. This fixes the following use case:

> var foo = 'bar \
... baz';
undefined
> foo
'bar baz'
>

Fixes nodejs#8874
@misterdjules
Copy link
Author

@joyent/node-coreteam Added a test as well, please let me know what you think. Thank you!

@cjihrig
Copy link

cjihrig commented May 12, 2015

Still LGTM

misterdjules pushed a commit that referenced this pull request May 13, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can
be considered as recoverable. This fixes the following use case:

> var foo = 'bar \
... baz';
undefined
> foo
'bar baz'
>

Fixes #8874

Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8875
@misterdjules
Copy link
Author

Thank you @cjihrig! Landed in 101e103.

misterdjules pushed a commit to nodejs/node that referenced this pull request Jun 25, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can
be considered as recoverable. This fixes the following use case:

> var foo = 'bar \
... baz';
undefined
> foo
'bar baz'
>

Fixes: nodejs/node-v0.x-archive#8874
PR-URL: nodejs/node-v0.x-archive#8875
PR-URL: #2052
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can
be considered as recoverable. This fixes the following use case:

> var foo = 'bar \
... baz';
undefined
> foo
'bar baz'
>

Fixes: nodejs/node-v0.x-archive#8874
PR-URL: nodejs/node-v0.x-archive#8875
PR-URL: nodejs#2052
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants