This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Allowing assert.deepEqual to check NaN values for equality #7920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Object may have NaN as one of its property values. NaN doesn't compare directly to itself, so isNaN() must be used instead.
|
I think this would be candidate for a |
|
@Fishrock123 if we were calling this strict, could we really say NaN === NaN since we don't know what the NaN truly represents? I was thinking it leaned more toward the loose (==) definition. The use case that served as the catalyst for this was comparing the deserialized version of an Object serialized into a binary format I devised. So technically, I actually want strict comparison. That said, either way could work for me. |
| // 7.4 If the expected value is NaN, we need to perform this comparison | ||
| // using isNaN(), as the next case will not catch the condition. | ||
| } else if (util.isNumber(expected) && isNaN(expected)) { | ||
| return isNaN(actual); |
There was a problem hiding this comment.
I think you're looking for Number.isNaN().
Corrected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Object may have NaN as one of its property values. NaN doesn't compare directly to itself, so isNaN() must be used instead.