This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Typo in Net createConnection's parameter name #7112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit Peekmo/node@f0f28e0 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
|
@Peekmo may I ask you to fix issues that was mentioned by @Nodejs-Jenkins ? Except them your PR LGTM |
|
Sorry, I hope that it's good right now :) |
|
Closing this here. New PR opened in https://github.com/nodejs/node |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#7112 originally submitted by @Peekmo
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#7112 originally submitted by @Peekmo Reviewed By: Sakthipriyan Vairamani <[email protected]> PR-URL: #2378
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#7112 originally submitted by @Peekmo Reviewed By: Sakthipriyan Vairamani <[email protected]> PR-URL: #2378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There were a typo in documentation, the listener of "createConnection" is listening to "connect" event. "connectionListener" name is so, a bad name because "connectionListener" for createServer() is listening to "connection" event ;)
Regards,
Peekmo