This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
tls: wrap tls inside tls using legacy API #6261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow wrapping TLSSocket inside another TLSSocket, emulate it using SecurePair in legacy APIs. fix nodejs#6204
|
|
||
| if (!options.socket) { | ||
| assert(!legacy); | ||
| var connect_opt = (options.path && !options.port) ? {path: options.path} : { |
There was a problem hiding this comment.
For readability's sake, can you change this into if/then/else statements?
Har har. :-) LGTM at a quick glance. I'd like @TooTallNate to take a peek / test it, too. |
| var legacy; | ||
| var result; | ||
| if (options.socket instanceof TLSSocket) { | ||
| console.log('legacy connect'); |
There was a problem hiding this comment.
That was supposed to be debug() call, forgot to change it back :)
|
Thanks, landed with small fix in 42acbf8. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow wrapping TLSSocket inside another TLSSocket, emulate it using
SecurePair in legacy APIs.
fix #6204
/cc @TooTallNate @bnoordhuis