debugger: also exit when the repl emits 'exit' #5637

fb55 · 2013-06-07T11:17:07Z

bnoordhuis · 2013-06-17T14:13:24Z

Raynos · 2014-12-26T01:27:07Z

👍 This will help with a wrapper around the node debugger that I'm writing.

cjihrig · 2014-12-29T15:27:22Z

lib/_debugger.js

+  }
+
+  // Exit debug repl on Ctrl + C
+  this.repl.rli.on('SIGINT', exitDebugRepl);


Could you use once() instead of on() so that you don't need to worry about removing the listener?

cjihrig · 2014-12-29T15:31:49Z

Ah, nevermind, using on() is fine here. LGTM

jasnell · 2015-08-13T16:51:50Z

@cjihrig ... this is targeted at master. Do we want to push this off to nodejs/node or get this landed in v0.12?

cjihrig · 2015-08-13T17:53:38Z

@jasnell let's take it to nodejs/node.

jasnell · 2015-08-13T17:56:07Z

@fb55... I know it's been a while, but are you willing to update this and open it against master in https://github.com/nodejs/node?

fb55 · 2015-08-13T18:22:39Z

jasnell · 2015-08-13T18:23:51Z

Thanks!

Exit the debug repl when repl emits 'exit' Refs: nodejs/node-v0.x-archive#5637 Fixes: nodejs/node-v0.x-archive#5631 PR-URL: #2369 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>

debugger: also exit when the repl emits 'exit'

de9230e

trevnorris mentioned this pull request Dec 6, 2013

Repl in node debug can only be exited using ctrl-c #5631

Closed

cjihrig reviewed Dec 29, 2014
View reviewed changes

jasnell added debugger repl labels Aug 6, 2015

jasnell self-assigned this Aug 13, 2015

fb55 mentioned this pull request Aug 13, 2015

debugger: also exit when the repl emits 'exit' nodejs/node#2369

Closed

jasnell closed this Aug 13, 2015

Provide feedback