This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
events: Don't assume .domain is a Domain instance #3998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventEmitter assumes that anything with a .domain property is an instance of a Domain.Domain. This clobbers any EventEmitter instances/inheriters that make use of the fairly generalized property name. Change is backwards compatible with existing interface. New test included. Fixes #3922
|
/cc @isaacs |
|
Can one of the admins verify this patch? |
|
This has been resolved by other issues, and besides, does not merge cleanly. Re-submit if it's still a thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventEmitter assumes that anything with a .domain property is an instance of a
Domain.Domain. This clobbers any EventEmitter instances/inheriters that make
use of the fairly generalized property name. Change is backwards compatible
with existing interface. New test included.
Fixes #3922
I know pull request 3932 is already open, but this would allow this to be fixed
in the next v0.8 release as opposed to 1.0.
#3932