This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
CryptoStream pass-through functions fix for setSocketKeepAlive #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng request is HTTPS. Fixed discarding of callback parameter when calling ClientRequest::setTimeout on HTTPS requests. Fixed discarding of noDelay parameter when calling ClientRequest::setNoDelay on HTTPS requests.
|
Thanks! Can you add a regression test? |
…red on both http and https requests.
|
I believe I have added a regression test (never done such a thing before, but copy and pasted one that looked similar). It crashes before my change, and runs fine after. |
|
Looks good. I'll merge it but can you sign the CLA first? |
|
I have now done so, thanks! |
|
Thanks Jimb, applied in 78db187. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crash calling ClientRequest::setSocketKeepAlive if the underlying request is HTTPS.
Fixed discarding of callback parameter when calling ClientRequest::setTimeout on HTTPS requests.
Fixed discarding of noDelay parameter when calling ClientRequest::setNoDelay on HTTPS requests.