This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
fs: Fix StatWatcher to handle error codes passed in status #25469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
brendanashworth
pushed a commit
to brendanashworth/io.js
that referenced
this pull request
Jun 22, 2015
Previously, fs.watchFile() would call the callback even if the file does not exist. This is erroneous and is fixed by correctly handling the error code provided. Ref: nodejs/node-v0.x-archive#25469 Fixes: nodejs#1745
|
@cjihrig Tests are added, can you take a look? |
|
It looks like io.js started to go down this path in nodejs/node#2028, but decided against it. The current proposed fix is in nodejs/node#2093. I think we should try to stay consistent with io.js in this case. |
|
@cjihrig Strictly speaking, nodejs/node#2093 is not a fix for this, it simply makes this as a documented feature :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25345