This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
V8 lateral 3.28 update #18206
Closed
V8 lateral 3.28 update #18206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@misterdjules Thanks much for taking the time to do this. Very appreciated. |
|
The test that was failing on Windows in the previous tests run does not fail anymore, although another test timed out. That test seems to be flakey too. In other words, we have more flaky tests and we'll need to take care of them, but I don't think they've been introduced by this PR. |
|
|
misterdjules
force-pushed
the
v8-lateral-3.28-update
branch
from
667d43c to
aa94a61
Compare
|
Just squashed the commit adding hidden files back into the main upgrade commit. @trevnorris What's your opinion about landing that in the upcoming v0.12.3 release? |
|
@misterdjules No qualms here. |
|
/cc @joyent/node-coreteam I will need a more formal review before landing this, and a LGTM if you agree we should land it for node v0.12.3. My opinion is that we should land it as soon as possible. Thank you! |
The 3.28.73 update was technically unstable code. This reverts the code to the latest 3.28 stable release.
Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs#8476
Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs#8476
Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8. Original commit message: Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N [email protected] Review URL: https://codereview.chromium.org/741683002 Cr-Commit-Position: refs/heads/master@{nodejs#25415}
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS.
misterdjules
force-pushed
the
v8-lateral-3.28-update
branch
from
aa94a61 to
46dc37e
Compare
|
LGTM |
|
Thank you @trevnorris! Landing soon. |
trevnorris
added a commit
that referenced
this pull request
Apr 29, 2015
The 3.28.73 update was technically unstable code. This reverts the code to the latest 3.28 stable release. Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
trevnorris
added a commit
that referenced
this pull request
Apr 29, 2015
Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
misterdjules
pushed a commit
that referenced
this pull request
Apr 29, 2015
Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
davepacheco
pushed a commit
that referenced
this pull request
Apr 29, 2015
Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
misterdjules
pushed a commit
that referenced
this pull request
Apr 29, 2015
Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8. Original commit message: Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N [email protected] Review URL: https://codereview.chromium.org/741683002 Cr-Commit-Position: refs/heads/master@{#25415} Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
misterdjules
pushed a commit
that referenced
this pull request
Apr 29, 2015
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS. Reviewed-By: Trevor Norris <[email protected]> PR-URL: #18206
cjihrig
added a commit
that referenced
this pull request
May 22, 2015
The Node 0.12 line was initially released with a version of v8 that included Array.prototype.values(). In #18206, v8 was updated to a version that dropped support for values(). https://codereview.chromium.org/647703003 removed this method because it causes problems with some versions of Outlook Web Access. This commit reverts the removal of Array.prototype.values(). Original commit message: Revert "Version 3.28.71.17 (merged r24706, r24708)" This reverts commit 529541ecb58fd0d6df4dfbe41d01bff9ae21ff06. Conflicts: src/version.cc Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25328
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work done in #9185. It's basically the same PR with some added floating patches and the hidden files put back in.
Tested on UNIX and Windows. The one test failing on Windows might be a flakey test, we'll need to make sure of that before landing this PR.
Fixes #9241.