This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Provide more descriptive error message in fs.readdir #1470
Labels
Comments
|
+1 |
ghost
assigned 
|
I'll take a stab at this. |
|
@sh1mmer, @ry I believe this is fixed : https://github.com/joyent/libuv/blob/master/src/unix/fs.c#L76 This was an issue when node wasn't using libuv. At that time, node was using the libeio struct directly and tested req->ptr1 to get the path. In eio__scandir(), ptr1 is freed (https://github.com/joyent/libuv/blob/master/src/unix/eio/eio.c#L1819). |
|
This has been fixed before the release of v0.6.0. Closing. |
wiedi
pushed a commit
to wiedi/node
that referenced
this issue
Aug 15, 2015
Notable changes:
* buffer:
- Due to changes in V8, it has been necessary to reimplement Buffer
on top of V8's Uint8Array. While every effort has been made to
maintain performance, users are likely to experience a different
performance profile depending on how Buffer is used.
(Trevor Norris) nodejs#1825.
- Buffer can now take ArrayBuffers as a constructor argument
(Trevor Norris) nodejs#2002.
- When a single buffer is passed to Buffer.concat(), a new, copied
Buffer object will be returned; previous behavior was to return
the original Buffer object (Sakthipriyan Vairamani) nodejs#1937.
* build: PPC support has been added to core to allow compiling on
pLinux BE and LE (AIX support coming soon) (Michael Dawson) nodejs#2124.
* dgram: If an error occurs within socket.send() and a callback has
been provided, the error is only passed as the first argument to the
callback and not emitted on the socket object; previous behavior was
to do both (Matteo Collina & Chris Dickinson) nodejs#1796
* freelist: Deprecate the undocumented freelist core module
(Sakthipriyan Vairamani) nodejs#2176.
* http:
- Status codes now all use the official IANA names as per RFC7231,
e.g. http.STATUS_CODES[414] now returns 'URI Too Long' rather than
'Request-URI Too Large' (jomo) nodejs#1470.
- Calling .getName() on an HTTP agent no longer returns a trailing
colon, HTTPS agents will no longer return an extra colon near the
middle of the string (Brendan Ashworth) nodejs#1617.
* node:
- NODE_MODULE_VERSION has been bumped to 45 to reflect the break in
ABI (Rod Vagg) nodejs#2096.
- Introduce a new process.release object that contains a name
property set to 'io.js' and sourceUrl, headersUrl and libUrl
(Windows only) properties containing URLs for the relevant
resources; this is intended to be used by node-gyp
(Rod Vagg) nodejs#2154.
- The version of node-gyp bundled with io.js now downloads and uses
a tarball of header files from iojs.org rather than the full
source for compiling native add-ons; it is hoped this is a
temporary floating patch and the change will be upstreamed to
node-gyp soon (Rod Vagg) nodejs#2066.
* repl: Persistent history is now enabled by default. The history file
is located at ~/.node_repl_history, which can be overridden by the
new environment variable NODE_REPL_HISTORY. This deprecates the
previous NODE_REPL_HISTORY_FILE variable. Additionally, the format
of the file has been changed to plain text to better handle file
corruption. (Jeremiah Senkpiel) nodejs#2224.
* smalloc: The smalloc module has been removed as it is no longer
possible to provide the API due to changes in V8
(Ben Noordhuis) nodejs#2022.
* tls: Add server.getTicketKeys() and server.setTicketKeys() methods
for TLS session key rotation (Fedor Indutny) nodejs#2227.
* v8: Upgraded to 4.4.63.26
- ES6: Enabled computed property names
- ES6: Array can now be subclassed in strict mode
- ES6: Implement rest parameters in staging, use the
--harmony-rest-parameters command line flag
- ES6: Implement the spread operator in staging, use the
--harmony-spreadcalls command line flag
- Removed SetIndexedPropertiesToExternalArrayData and related APIs,
forcing a shift to Buffer to be reimplemented based on Uint8Array
- Introduction of Maybe and MaybeLocal C++ API for objects which may
or may not have a value.
- Added support for PPC
PR-URL: nodejs/node#2299
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When fs.readFile is called with wrong path it throws error with message:
When we do same to fs.readdir it throws similar error but without path information:
It'll be really helpful to have there path information as well. It's quite important when we deal with chained asynchronous calls and need to track from which call error comes from. I guess it should say:
The text was updated successfully, but these errors were encountered: