http: rename flush to flushHeaders

In order to preserve the potential for a flush method being added to the streams API, rename flush to flushHeaders which is much more clear about the behavior of this method. PR: #9048 PR-URL: #9048 Reviewed-By: Julien Gilli <[email protected]>
nodejs · Jan 16, 2015 · 89f3c90 · 89f3c90
1 parent efe1781
commit 89f3c90
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/doc/api/http.markdown b/doc/api/http.markdown
@@ -855,7 +855,7 @@ Emitted when the server sends a '100 Continue' HTTP response, usually because
 the request contained 'Expect: 100-continue'. This is an instruction that
 the client should send the request body.
 
-### request.flush()
+### request.flushHeaders()
 
 Flush the request headers.
 

diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -613,7 +613,7 @@ OutgoingMessage.prototype._flush = function() {
 };
 
 
-OutgoingMessage.prototype.flush = function() {
+OutgoingMessage.prototype.flushHeaders = function outgoingFlushHeaders() {
   if (!this._header) {
     // Force-flush the headers.
     this._implicitHeader();

diff --git a/test/simple/test-http-flush.js b/test/simple/test-http-flush.js
@@ -32,6 +32,6 @@ http.createServer(function(req, res) {
     host: '127.0.0.1',
     port: common.PORT,
   });
-  req.flush();  // Flush the request headers.
-  req.flush();  // Should be idempotent.
+  req.flushHeaders();  // Flush the request headers.
+  req.flushHeaders();  // Should be idempotent.
 });