Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

chore: align message with Node.js standard #89

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 19, 2020

Node.js uses (or will use) Ctrl+C with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.

Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.
@jkrems jkrems merged commit 9d8cd2b into nodejs:master Sep 21, 2020
@jkrems
Copy link
Collaborator

jkrems commented Sep 21, 2020

Is there a timeline for getting this back into node? Or is it a "when convenient"?

@Trott
Copy link
Member Author

Trott commented Sep 22, 2020

Is there a timeline for getting this back into node? Or is it a "when convenient"?

When convenient.

@Trott
Copy link
Member Author

Trott commented Sep 22, 2020

Is there a timeline for getting this back into node? Or is it a "when convenient"?

When convenient.

Meaning: When convenient for you and other node-inspect maintainers. If you'd rather have it get into Node.js sooner than later, I'm happy to do whatever I can to make that easier if there's anything that's an obstacle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants