Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

test: custom port #38

Closed
wants to merge 1 commit into from
Closed

test: custom port #38

wants to merge 1 commit into from

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Mar 28, 2017

  • adds a test for a custom port specified with --port
  • use --inspect-brk instead of --debug-brk
  • fixes regex for default port to consider --inspect=<port> and --inspect-brk=<port> as well as --inspect-port=<port>, since all of these are supported per src/node_debug_options.cc.
  • look for 'Debugger listening on..." rather than chrome-devtools for better future-proofness.

@jkrems
Copy link
Collaborator

jkrems commented Mar 28, 2017

:shipit:

@jkrems
Copy link
Collaborator

jkrems commented Mar 28, 2017

@jkrems
Copy link
Collaborator

jkrems commented Mar 28, 2017

Ugh, CI doesn't pass because the bad test is still around: #36

Could you have a quick look at that PR and then rebase once it's merged?

@jkrems jkrems closed this Apr 3, 2017
@jkrems jkrems mentioned this pull request Apr 3, 2017
@jkrems
Copy link
Collaborator

jkrems commented Apr 3, 2017

Rebased version here: #41

@joshgav
Copy link
Contributor Author

joshgav commented Apr 4, 2017

Thanks and sorry for my delay in picking it back up!

@jkrems
Copy link
Collaborator

jkrems commented Apr 4, 2017

No worries. I was just "stealing" the commit because I want to do another dep pull later this week & wanted to make sure that it's included.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants