Delay run until breakpoints are restored #34
Conversation
| @@ -8,7 +8,9 @@ const startCLI = require('./start-cli'); | |||
| test('examples/empty.js', (t) => { | |||
| const script = Path.join('examples', 'empty.js'); | |||
| const cli = startCLI([script]); | |||
| return cli.waitForPrompt() | |||
|
|
|||
| return cli.waitFor(/break/) | |||
There was a problem hiding this comment.
This matches how all other test files are doing it. There really should be a cli.waitForInitialPrompt helper.
|
CI Runs Build for everything but win10 passing: https://ci.nodejs.org/view/x%20-%20Diagnostics/job/node-inspect-continuous-integration/15/ With the 2nd commit for win10: https://ci.nodejs.org/view/x%20-%20Diagnostics/job/node-inspect-continuous-integration/16/MACHINE=win10/console |
|
Down to one win10 failure ("sb before loading file"): https://ci.nodejs.org/view/x%20-%20Diagnostics/job/node-inspect-continuous-integration/17/MACHINE=win10/console EDIT: Nevermind, that's actually an 8.x-nightly failure in general. Can reproduce on OSX. EDIT 2: The same failure ("sb before loading file") also reproduces on latest 7.x. |
|
|
||
| const startCLI = require('./start-cli'); | ||
|
|
||
| test('for whiles that starts with strict directive', (t) => { |
There was a problem hiding this comment.
Added this test for documentation purposes and to make sure that adding a strict directive doesn't actually break everything.
|
/cc @nodejs/diagnostics Now the build is all green for node 6 (smartos fails way before it starts running anything): https://ci.nodejs.org/job/node-inspect-continuous-integration/22/ Build against 8.x-nightly 100% green: https://ci.nodejs.org/job/node-inspect-continuous-integration/23/ P.S.: Yes, for AIX I'm cheating a bit. Still worth investigating but it's at least highly localized and mostly cosmetic. |
|
Created #35 for following up on the AIX issue. |
Tested this by delaying the ready event by 250ms and going from there.