download headers tarball for ~0.12.10 || ~0.10.42 #877
Conversation
|
I'd consider this a semver-minor and warrants introduction into npm@2 if we can manage it. There's some queued up changes that need to go out with the next 0.10 and 0.12 so that could be done fairly soon. So /cc @zkat. |
| @@ -93,7 +95,7 @@ function processRelease (argv, gyp, defaultVersion, defaultRelease) { | |||
| // making the bold assumption that anything with a version number >3.0.0 will | |||
| // have a *-headers.tar.gz file in its dist location, even some frankenstein | |||
| // custom version | |||
| tarballUrl = url.resolve(baseUrl, name + '-v' + version + (versionSemver.major >= 3 ? '-headers' : '') + '.tar.gz') | |||
| tarballUrl = url.resolve(baseUrl, name + '-v' + version + (semver.satisfies(versionSemver, headersTarballRange) ? '-headers' : '') + '.tar.gz') | |||
|
LGTM sans style nit. The commit log could go into more detail. |
Properly created -headers.tar.gz files were not available until v0.12.10 and v0.10.42 (in addition to >= 3).
rvagg
force-pushed
the
headers-0.10-0.12
branch
from
9ecd001
to
941e24f
Compare
|
thanks @bnoordhuis, both addressed |
|
LGTM but can you |
|
Do we care about xz at this stage? Benefitting from headers only is good enough? Anyway, I can likely represent the Internet Bandwidth Committee stating LGTM. |
|
@jbergstroem I'd love to use xz for these but we don't have xz support from zlib so uncompressing them without invoking system tools is tricky. I've considered pulling in a JS implementation but haven't done any research on whether they exist or whether they are any good. Given that we're talking about ~500kb the effort in researching and coding it up is unlikely to yield enough benefit to warrant me bothering! |
|
^ that's not to say I wouldn't support someone else doing this work if they feel it's an interesting enough challenge and worth their time, it's just not worth my time |
Properly created -headers.tar.gz files were not available until v0.12.10 and v0.10.42 (in addition to >= 3). PR-URL: #877 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
|
landed @ 070fe69 |
Properly created -headers.tar.gz files were not available until v0.12.10 and v0.10.42 (in addition to >= 3). PR-URL: #877 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
/R= @nodejs/build @ljharb I guess