Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Node.js to build with Microsoft's ChakraCore engine #873

Closed
wants to merge 4 commits into from

Commits on Jan 19, 2017

  1. gyp: Add support to build node.js with chakracore

    Microsoft's chakracore engine is dependent on Windows SDK, and build tools
    should know the version installed on user machine. This change adds those
    dependencies in node-gyp tools. Below is the summary:
    
    * Configure msvs_windows_target_platform_version to use the right
       Windows SDK.
    * Configure msvs_use_library_dependency_inputs to export symbols
       correctly (otherwise functions not used by node.exe but might be
       needed by native addon modules could be optimized away by linker).
    
     These changes were originally made in nodejs/node#4765, but as @shigeki
     mentioned, it was more sensible to send these changes as PR to node-gyp
     repo.
    kunalspathak committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    7e56293 View commit details
    Browse the repository at this point in the history
  2. gyp: Add support to build node.js with chakracore for ARM

    * Support building node.js with chakracore on Windows on ARM
    * Building chakracore for ARM has a dependency on Windows SDK installed
       on the machine. Update python script to populate
       `WindowsSDKDesktopARMSupport` and `WindowsTargetPlatformVersion`
        for ARM builds. This will be using in node repo to build`chakracore.gyp`.
    kunalspathak committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    3c03d3e View commit details
    Browse the repository at this point in the history
  3. Review feedback

    Moved definition of `node_engine_include_dir` from
    `node-chakracore` to this repo.
    kunalspathak committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    26207f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2017

  1. Fix for CI test failure

    * Fixed CI test failure
    * Addressed review feedback
    kunalspathak committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    5b54dba View commit details
    Browse the repository at this point in the history