Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: Update graceful-fs dependency to the latest #714

Closed
wants to merge 1 commit into from
Closed

dep: Update graceful-fs dependency to the latest #714

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.

This might also fix nodejs/node#2714 (comment)

@@ -24,7 +24,7 @@
"dependencies": {
"fstream": "^1.0.0",
"glob": "3 || 4",
"graceful-fs": "3",
"graceful-fs": "4.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use ^ notation here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis Sure. Done :-)

@bnoordhuis
Copy link
Member

LGTM

@Fishrock123
Copy link
Contributor

LGTM if it works

@bnoordhuis
Copy link
Member

@thefourtheye Do you have a commit bit or should I land it for you?

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.
@thefourtheye
Copy link
Contributor Author

@bnoordhuis I had to update my email in the commit log and its done now. I don't have commit access to this repo, so you can land this.

bnoordhuis pushed a commit that referenced this pull request Sep 6, 2015
graceful-fs used to monkey-patch node's core fs module.
This has been fixed in version 4.

PR-URL: #714
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@bnoordhuis
Copy link
Member

Thanks Sakthipriyan, landed in 1ea7ed0. Let me know if you plan to work on node-gyp more and I'll give you your commit bit.

@bnoordhuis bnoordhuis closed this Sep 6, 2015
@thefourtheye thefourtheye deleted the patch-1 branch September 6, 2015 18:13
@thefourtheye
Copy link
Contributor Author

@bnoordhuis Sure. I ll start by monitoring the PRs and issues. Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants