Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gyp): update gyp to v0.12.1 #2642

Closed
wants to merge 3 commits into from
Closed

feat(gyp): update gyp to v0.12.1 #2642

wants to merge 3 commits into from

Conversation

dmabupt
Copy link

@dmabupt dmabupt commented Apr 11, 2022

Related PR: #2626

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could jump straight to gyp-next 0.12.1.

@dmabupt dmabupt changed the title feat(gyp): update gyp to v0.11.0 feat(gyp): update gyp to v0.12.1 Apr 15, 2022
@dmabupt
Copy link
Author

dmabupt commented Apr 15, 2022

LGTM. We could jump straight to gyp-next 0.12.1.

Hello @richardlau , I have updated it to v0.12.1. But there are lots of ci failures.

@dmabupt
Copy link
Author

dmabupt commented Apr 18, 2022

Duplicated PR -- nodejs/node@b99bb57
Close this.

@dmabupt dmabupt closed this Apr 18, 2022
@rvagg
Copy link
Member

rvagg commented Apr 19, 2022

Duplicated PR -- nodejs/node@b99bb57

but that PR is on nodejs/node, not nodejs/node-gyp, so I think we're still in need of a gyp-next upgrade here aren't we?

@kadler
Copy link
Contributor

kadler commented Apr 22, 2022

Yes, we still need this PR. @dmabupt can you please re-open?

Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sync with gyp-next, not nodejs/node gyp folder. Currently they are not align.

@kadler
Copy link
Contributor

kadler commented Aug 18, 2022

This can be closed in favor of #2626, which now also updates gyp from gyp-next 0.13.0

@dmabupt
Copy link
Author

dmabupt commented Sep 19, 2022

Close this issue due to #2626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants