-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to semver ≥ 7 (Fixes: #2005) #2006
Conversation
I'm not keen on this, our package.json has been optimised to fit nicely with npm's so that there's a lot of deduplication. Both node-gyp and npm currently have |
(Following on from discussion in #2006) The So back out the package.json change, leaving us with semver@5, and I'll lift my objection. Without anyone else objecting we should be able to merge this (with a bit of manual testing). We'll bump to semver@7 when npm does--which may be sooner than later with the retirement of Node.js 8 (i.e. a lot of npm's dependencies have moved to support newer JS features that aren't supported by Node.js 8). I'll +1 this change since it's trivial, but it's not an endorsement (from me at least) of dancing around the incompatible bundling policies of Debian et. al.. That's something you either have to continue to manually patch your way around or push for some policy leniency for runtime ecosystems such as Node.js, whose dependency systems are incompatible with the existing distro policies. |
Done, thanks. Of course, Debian Developer will continue to manually patch the node.js module they need 😉 |
Fixes: #2005 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2006
landed f242ce4 |
Fixes: #2005 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2006
Fixes: #2005 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2006
Description of change
This PR updates semver to 7.x. and fixes #2005