win: support VS 2017 Desktop Express #1902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Oct 2, 2019
|
landed in 968c906 |
rvagg
pushed a commit
that referenced
this pull request
Oct 3, 2019
Fixes: #1881 PR-URL: #1902 Reviewed-By: Rod Vagg <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 3, 2019
Fixes: #1881 PR-URL: #1902 Reviewed-By: Rod Vagg <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 4, 2019
Fixes: #1881 PR-URL: #1902 Reviewed-By: Rod Vagg <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 4, 2019
Fixes: #1881 PR-URL: #1902 Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Visual Studio Express does not install the
Microsoft.VisualStudio.Component.VC.Tools.x86.x64we use to know the Toolset is installed. Since VS Express is not customizable, we can just check for it and keep the current behavior for other editions.Fixes: #1881