Undefined name: cflags --> ldflags #1901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
pushed a commit
that referenced
this pull request
Oct 2, 2019
The current code would raise NameError at runtime. PR-URL: #1901 Reviewed-By: Rod Vagg <[email protected]>
|
landed in a84b885, label semver-major if it shouldn't be backported |
|
This can be backported... My suspicion is that this part of the code is never run because if it was, the NameError would be raised at runtime. |
|
This landed but is still open? |
rvagg
pushed a commit
that referenced
this pull request
Oct 2, 2019
The current code would raise NameError at runtime. PR-URL: #1901 Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rvagg This would be good to land before #1892
The current code would raise NameError at runtime.
Checklist
npm install && npm testpassesDescription of change