build: import StringIO on both Python 2 and Python 3 #1836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Jul 22, 2019
This change supports access to StringIO on both Python 2 and Python 3
cclauss
force-pushed
the
ninja.py-StringIO
branch
from
e7b38e0
to
c3f12dc
Compare
|
|
cclauss
changed the title
MattIPv4
reviewed
Jul 23, 2019
| @@ -8,7 +8,6 @@ | |||
|
|
|||
| import gyp.generator.ninja as ninja | |||
| import unittest | |||
| import StringIO | |||
There was a problem hiding this comment.
Does it not need to be replaced here?
There was a problem hiding this comment.
Nevermind, looks like it isn't actually used here.
4 tasks
joaocgreis
pushed a commit
that referenced
this pull request
Jul 23, 2019
This change supports access to StringIO on both Python 2 and Python 3 PR-URL: #1836 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: João Reis <[email protected]>
joaocgreis
approved these changes
Jul 23, 2019
|
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/150/ Landed in 5459eca. @cclauss I've squashed both commits, please let me know if I made a mistake. Thanks! |
rvagg
pushed a commit
that referenced
this pull request
Sep 26, 2019
This change supports access to StringIO on both Python 2 and Python 3 PR-URL: #1836 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: João Reis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports access to StringIO on both Python 2 and Python 3. Without this change the import fails on Python 3.
Checklist
npm install && npm testpassesDescription of change