-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 asm #1679
Add arm64 asm #1679
Conversation
29998a3
to
96472fa
Compare
This is a much smaller change than #1678, but they may overlap some. |
This PR is redundant with upgrading node-gyp's GYP to refack/GYP. |
This change allows MSVS projects generated for ARM64 to include ASM files.
#1678's GYP-specific parts were separated into refack/GYP3#33, then that was ported back as #1739. It might have a merge conflict with this PR, but they do not functionally overlap. |
This change allows MSVS projects generated for ARM64 to include ASM files. PR-URL: nodejs#1679 Reviewed-By: João Reis <[email protected]>
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/126/ ✔️ Landed in 721eb69 Thanks! |
Checklist
npm install && npm test
passesDescription of change
This is a port of nodejs/node#26020 (see also refack/GYP3#23) to the
node-gyp
copy of GYP. It is important when building Node.js itself (V8 has ASM bits; hence the other PR) and when building native modules with ASM (fairly rare, as I understand it).