Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: move compile_commands_json #1661

Conversation

paul-marechal
Copy link
Contributor

It isn't possible to access
tools/gyp/pylib/gyp/generator/compile_commands_json.py using the
--format option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526

Signed-off-by: Paul Maréchal [email protected]

Checklist
Description of change

Should allow us to use the compile_commands_json formatter/generator.

It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: nodejs#1526

Signed-off-by: Paul Maréchal <[email protected]>
@paul-marechal
Copy link
Contributor Author

If I missed something and this change isn't actually required, please tell me :)

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

In case you're wondering: this file was brought over from nodejs/node@3c46bb9931 where gyp lives in tools/gyp. :-)

bnoordhuis pushed a commit that referenced this pull request Feb 12, 2019
It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526
PR-URL: #1661
Reviewed-By: Ben Noordhuis <[email protected]>
Signed-off-by: Paul Maréchal <[email protected]>
@bnoordhuis
Copy link
Member

Landed in 2349dba, thanks Paul.

@bnoordhuis bnoordhuis closed this Feb 12, 2019
@paul-marechal paul-marechal deleted the mp/move_compile_commands_json branch February 13, 2019 19:46
rvagg pushed a commit that referenced this pull request Apr 24, 2019
It isn't possible to access
`tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the
`--format` option.

This commit moves the file in a place where it can be accessed.

Fixes: #1526
PR-URL: #1661
Reviewed-By: Ben Noordhuis <[email protected]>
Signed-off-by: Paul Maréchal <[email protected]>
@rvagg rvagg mentioned this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants