win: improve parsing of SDK version #1516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
approved these changes
Jul 31, 2018
|
cc @refack |
Closed
refack
approved these changes
Aug 1, 2018
richardlau
approved these changes
Aug 1, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: nodejs#1466
|
@joaocgreis I've changed the commit message to point to the correct issue (#1466) |
joaocgreis
pushed a commit
that referenced
this pull request
Aug 8, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: #1466 PR-URL: #1516 Reviewed-By: João Reis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
joaocgreis
pushed a commit
that referenced
this pull request
Aug 8, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: #1466 PR-URL: #1516 Reviewed-By: João Reis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
CI was green, additional run on v0.12 to check the backport to v3.x: https://ci.nodejs.org/job/nodegyp-test-commit/422/ (also green). Landed in 25208f1 ( Thanks @Loghorn! |
3 tasks
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.
Fixes: #1144