gyp: fix regex to match multi-digit versions

[jhermsmeier]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

This fixes the regular expression matching in xcode_emulation
to also handle version numbers with multiple-digit major versions
which would otherwise break under use of XCode 10

Fixes: #1454

[jhermsmeier]

There currently aren't any tests for this particular part of the code – should I add some? If so, I think I could do with some guidance on that

[bnoordhuis]

LGTM, thanks.

As to testing, there's no direct way to test this code since it lives inside gyp, not node-gyp, which has its own external test suite.

[jhermsmeier]

Oh, I see, of course – not sure where my head was. I guess it would be preferable to land this upstream (if it hasn't been patched there yet)?

[bnoordhuis]

Ideally, yes, but Google has effectively abandoned gyp so we're in this awkward situation where we're the de facto (but not de jure) upstream.

[Trott]

I've confirmed that this change along unbreaks things on macOS High Sierra with CLI tools. Can we expedite landing and publishing?

[Trott]

/ping @nodejs/node-gyp

[bnoordhuis]

Merged in 293092c (commit 40f24e4 on the v3.x branch) and released as v3.6.3. Thanks again, Jonas.

[jhermsmeier]

Sweet, thank you for the swift response!

[questsin]

still an issue

[nornagon]

Hm, I'm not sure this has fully addressed the issue. On my system, XcodeVersion() is returning "0101", which causes gyp to assume we want to target i386 (among other poor assertions). It seems like this only fixed the CLTVersion path, not the xcodebuild -version path?

[cclauss]

@nornagon Would it be possible to add a new Travis CI run which mimics your Mac setup?

• https://github.com/nodejs/node-gyp/blob/master/.travis.yml#L10-L14
• https://docs.travis-ci.com/user/reference/osx