Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update macOS information in README #1323

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Conversation

josh-
Copy link
Contributor

@josh- josh- commented Nov 4, 2017

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • Changed occurrences of "Mac OS X" to "macOS" as per Apple's recent rebranding
  • Added information about xcode-select --install (an alternative to downloading developer tools from the Xcode UI)
  • Deleted duplicate macOS build information from the Windows section of the README

Fixes #1295

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@maclover7 maclover7 merged commit 91789c2 into nodejs:master Jun 8, 2018
@maclover7
Copy link
Contributor

Landed in 91789c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text in readme in wrong place
4 participants