-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: pin request
to ~2.81.0
#1300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it's going to diverge (and more importantly: cause duplication) when npm upgrades to request 2.9.0.
Another thing, if we ever decide to upgrade the node-gyp in the v4.x and v6.x branches, that too would result in duplication: their copies of npm are stuck on [email protected]. Not the end of the world, just something to keep in mind. |
I'll test if |
Indeed setting to
|
@refack can you also give the minimum version in that specifier if you use |
Ack. |
thanks! |
Ping @refack. |
Required for "node < 4" compatibility and is congruent with `npm` minimum for passing `npm test` >= 2.9.0 setting < 2.82.0 allows deduping PR-URL: #1300 Fixes: #1299 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
a60bd45
to
7900122
Compare
@refack Could you please release of the 3.x with this change ? |
Required for "node < 4" compatibility and is congruent with `npm` minimum for passing `npm test` >= 2.9.0 setting < 2.82.0 allows deduping PR-URL: #1300 Fixes: #1299 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Required for "node < 4" compatibility and is congruent with `npm` minimum for passing `npm test` >= 2.9.0 setting < 2.82.0 allows deduping PR-URL: #1300 Fixes: #1299 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Checklist
npm install && npm test
passesDescription of change
Required for "node < 4" compatibility and is congruent with
npm
Fixes: #1299