Detect visual studio 2017

[danielgindi]

This should have been done long ago...

[refack]

@danielgindi thanks for the contribution! 🥇
As of [email protected] detection of VS2017 is already in.
(if you don't have > v3.6.0 you'll need to update npm)

[danielgindi]

Actually 3.6.1 is installed, a fresh install - and do not have the VS2017 detection in...
It does use it somehow with an env called GYP_MSVS_OVERRIDE_PATH, which does not exist on my system so I have no idea where it comes from.
But on another system - also 3.6.1 just installed fresh - no VS2017 detection...

[refack]

It does use it somehow with an env called GYP_MSVS_OVERRIDE_PATH

https://github.com/nodejs/node-gyp/blob/master/lib/configure.js#L156

We wanted to have VS2017 support before it landed in upstream GYP so we "lie" to it to make it work.
If you can't build with v3.6.1 please supply the error output. Also look if it's related to #1179

[danielgindi]

Okay so I've debugged the configure.js, and findVS2017 says that "Error: Could not use PowerShell to find VS2017"
Looking further into it...

[refack]

See if this #1198 helps

[danielgindi]

'Exception calling "Query" with "0" argument(s): "Input string was not in a correct format."\r\nAt line:1 char:95\r\n+ ... e-gyp\\lib\\Find-VS2017.cs\'; [VisualStudioConfiguration.Main]::Query()}\r\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n + CategoryInfo : NotSpecified: (:) [], MethodInvocationException\r\n + FullyQualifiedErrorId : FormatException\r\n \r\n'

[danielgindi]

Yes, #1198 solves it. So we're waiting for v3.6.2, and for it to reach npm upstream...

[danielgindi]

Seems like Windows Creators Update has this side effect of making vs2017 harder to detect by the old code.
This really needs to be released soon...

[refack]

Will be in [email protected]

[refack]

Will be in [email protected]
Ref: npm/npm#16894