Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI build failures in test/test-find-python.js #1826

Closed
cclauss opened this issue Jul 16, 2019 · 1 comment
Closed

Travis CI build failures in test/test-find-python.js #1826

cclauss opened this issue Jul 16, 2019 · 1 comment
Assignees
@joaocgreis
Labels
build

Comments

@cclauss
Copy link
Contributor

cclauss commented Jul 16, 2019 •
edited
Loading

As discussed at #1820 (comment)

  • Node Version: master
  • Platform: Travis CI (Linux)
  • Compiler:
  • Module: test
Verbose output (from npm or node-gyp):

In #1815 at https://travis-ci.com/nodejs/node-gyp/jobs/214789663#L4479-L4504
@cclauss cclauss added the build label Jul 16, 2019
@cclauss cclauss mentioned this issue Jul 16, 2019
Closed
cclauss added a commit to cclauss/node-gyp that referenced this issue Jul 16, 2019
@cclauss
Workaround for nodejs#1826
d685451
@cclauss
Copy link
Contributor Author

cclauss commented Jul 17, 2019 •
edited
Loading

https://bugs.python.org/issue18338

  • python2 --version writes to stderr
  • python3 --version writes to stdout

https://github.com/nodejs/node-gyp/blob/master/test/test-find-python.js#L16-L26
I thought that the following would do the trick but it broke even more tests.

-       t.strictEqual(stdout, '')
-       t.ok(/Python 2/.test(stderr))
+       t.ok(/Python 2/.test(stderr) || /Python 3/.test(stdout))

@cclauss cclauss mentioned this issue Jul 23, 2019
Closed
4 tasks
rvagg pushed a commit that referenced this issue Sep 26, 2019
@joaocgreis @rvagg
test: accept Python 3 in test-find-python.js
2e24d0a 
Fixes: #1826
PR-URL: #1843
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Matt Cowley <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaocgreis joaocgreis

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaocgreis @cclauss