Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use plaintext formatting in release commit #417

Merged
merged 1 commit into from
May 11, 2020

Conversation

codebytere
Copy link
Member

Refs. nodejs/branch-diff#22.

Leverages new plaintext functionality in branch-diff so that we can easily pull the notable changes into release commits without markdown cruft. New sample output:

build:
  * add --error-on-warn configure flag (Daniel Bevenius) https://github.com/nodejs/node/pull/32685
cluster:
  * fix error on worker disconnect/destroy (Santiago Gimeno) https://github.com/nodejs/node/pull/32793
crypto:
  * check DiffieHellman p and g params (Ben Noordhuis) https://github.com/nodejs/node/pull/32739
  * generator must be int32 in DiffieHellman() (Ben Noordhuis) https://github.com/nodejs/node/pull/32739
  * key size must be int32 in DiffieHellman() (Ben Noordhuis) https://github.com/nodejs/node/pull/32739

cc @targos

@codebytere codebytere requested a review from targos May 11, 2020 18:56
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   76.34%   76.34%           
=======================================
  Files          21       21           
  Lines        1484     1484           
=======================================
  Hits         1133     1133           
  Misses        351      351           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d9c61...48481c2. Read the comment docs.

@codebytere codebytere force-pushed the add-plaintext-commit-format branch from 6e3093a to 48481c2 Compare May 11, 2020 19:34
@codebytere codebytere merged commit 8e6ac47 into nodejs:master May 11, 2020
@codebytere codebytere deleted the add-plaintext-commit-format branch May 11, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants