Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color prs purple #264

Closed
devsnek opened this issue Jul 16, 2018 · 8 comments
Closed

color prs purple #264

devsnek opened this issue Jul 16, 2018 · 8 comments
Labels
enhancement Things that enhances functionality, provided by node-core-utils git-node

Comments

@devsnek
Copy link
Member

devsnek commented Jul 16, 2018

from the collab guide:

Optional: When landing your own commits, force push the amended commit to the
branch you used to open the pull request. If your branch is called `bugfix`,
then the command would be `git push --force-with-lease origin master:bugfix`.
When the pull request is closed, this will cause the pull request to
show the purple merged status rather than the red closed status that is
usually used for pull requests that weren't merged.
@priyank-p priyank-p added enhancement Things that enhances functionality, provided by node-core-utils git-node labels Jul 17, 2018
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 16, 2020
@ljharb
Copy link
Member

ljharb commented Aug 16, 2020

ping

@priyank-p priyank-p removed the stale label Aug 17, 2020
@mmarchini
Copy link
Contributor

Hopefully we can get this working with the new commit-queue

@codebytere codebytere mentioned this issue Aug 19, 2020
Closed
mmarchini added a commit to mmarchini/node that referenced this issue Aug 31, 2020
@mmarchini
build: use purple merge instead of close on CQ
77a9be9 
If the bot can make modifications to the head branch, force push to the
head branch so it lands with the purple icon on GitHub instead of the
red icon when the PR is closed. Let's gooooooooo!

Ref: nodejs/node-core-utils#264
@mmarchini mmarchini mentioned this issue Aug 31, 2020
Closed
4 tasks
aduh95 pushed a commit to nodejs/node-auto-test that referenced this issue Oct 9, 2020
@mmarchini @aduh95
build: use purple merge instead of close on CQ
043af6e 
If the bot can make modifications to the head branch, force push to the
head branch so it lands with the purple icon on GitHub instead of the
red icon when the PR is closed. Let's gooooooooo!

Ref: nodejs/node-core-utils#264
Trott pushed a commit to nodejs/node-auto-test that referenced this issue Oct 11, 2020
@mmarchini @Trott
build: use purple merge instead of close on CQ
2cca46b 
If the bot can make modifications to the head branch, force push to the
head branch so it lands with the purple icon on GitHub instead of the
red icon when the PR is closed. Let's gooooooooo!

Ref: nodejs/node-core-utils#264
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 16, 2020
@ljharb
Copy link
Member

ljharb commented Nov 16, 2020

bump

@mmarchini mmarchini removed the stale label Nov 16, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Feb 15, 2021
@ljharb
Copy link
Member

ljharb commented Feb 15, 2021

bump forever

@targos targos added never stale and removed stale labels Feb 15, 2021
@targos targos removed the never stale label Mar 3, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 11, 2023

I think we can close this, the CQ is able to purple merge PRs that land one commit, the current workflow seems to be an appropriate compromise.

@aduh95 aduh95 closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Things that enhances functionality, provided by node-core-utils git-node
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ljharb @targos @mmarchini @devsnek @aduh95 @priyank-p