Skip to content

Commit

Permalink
pr_checker: show the pr author email and their status
Browse files Browse the repository at this point in the history
  • Loading branch information
joyeecheung committed Nov 23, 2017
1 parent 7947bb2 commit edd107a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/pr_checker.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ class PRChecker {
return true;
}

const prAuthor = pr.author.login;
cli.warn(`PR author is: @${prAuthor}`);
const prAuthor = `${pr.author.login}(${pr.author.email})`;
cli.warn(`PR author is a new contributor: @${prAuthor}`);
for (const c of oddCommits) {
const { oid, author } = c.commit;
const hash = oid.slice(0, 7);
Expand Down
2 changes: 1 addition & 1 deletion test/unit/pr_checker.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ describe('PRChecker', () => {

const expectedLogs = {
warn: [
['PR author is: @pr_author'],
['PR author is a new contributor: @pr_author([email protected])'],
['- commit e3ad7c7 is authored by [email protected]'],
['- commit da39a3e is authored by [email protected]']
]
Expand Down

0 comments on commit edd107a

Please sign in to comment.