Update convergance #7
Conversation
Update the repository README file to accurately reflect the intent and nature of this repository. The original io.js README is preserved as iojs_README.md. This is temporary just while the convergence process gets underway. Once the repository moves over to the official organization, this can be reverted back to an actual project README that accurately reflects the combined projects. Reviewed-By: @jasnell James M Snell <[email protected]> Reviewed-By: @Fishrock123 Jeremiah Senkpiel PR-URL: nodejs/node-convergence-archive#4
Conflicts: README.md
|
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/671/ (Currently not perfect, there's a fix for one issue coming soon and the windows issues may be jenkins-related.) |
|
LGTM at this point modulo the additional issue and the resolution on the windows issue. |
Conflicts: README.md
Fishrock123
force-pushed
the
update-convergance
branch
from
0d00805
to
8e6bd77
Compare
|
Updated. CI at this point now looks like: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/676/ |
|
(Still need to CI-bisect the windows things.) |
|
Ok, looking at the CI, things look good except for the windows bits obviously. @Fishrock123, what's the status on those? I'm comfortable landing this with those red but it would good to get those working. |
|
It appears to be jenkins trolling us: nodejs/node#1679 (comment) If you have a windows machine you could try it, but it'l almost certainly pass locally. (unless one of the lingering rarely-pops-up failures hits) Edit: specifically, you may rarely see nodejs/node#1100 |
|
👍 |
|
Used |
|
👍 |
|
Also pushed the rebase version to |
R=@jasnell
I'll rebase master ontop of c58264e once accepted.