This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: correct Template properties support #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/chakracore Please review. Thanks! |
|
LGTM |
Template (ObjectTemplate, FunctionTemplate) properties can be Templates. When creating Template instances, Template properties need to be replaced with corresponding Template instantiations. `nodejs/master` starts to depend on this feature. PR-URL: nodejs#64 Reviewed-By: Sandeep Agarwal <[email protected]>
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Jun 29, 2016
chakrashim: Code cleanup Reviewed most of the CHAKRA-TODO for error handling and updated the code accordingly. Removed these comments from the code. Minor clean up to undo the @eb3d8ba now Chakra propagates the OOM errors. Converted keepalive property name to symbols.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template (ObjectTemplate, FunctionTemplate) properties can be Templates.
When creating Template instances, Template properties need to be replaced
with corresponding Template instantiations.
nodejs/masterstarts to depend on this feature.