This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
deps: fix libuv registry API error handling #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
changed the title
|
Upstream PR: libuv/libuv#1811 |
kfarnung
force-pushed
the
armcrash
branch
5 times, most recently
from
3c3de2a to
f877277
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 22, 2018
The `Reg*` APIs on Windows don't use `GetLastError` to report failures. The errors are returned directly from the call. For systems which don't have one of the values `GetLastError` can end up returning `0` to the caller, indicating success. The caller then assumes that the data is valid and can attempt to execute on garbage data. This change fixes the flow to correctly return the error to the caller. Upstream-PR: libuv/libuv#1811 PR-URL: nodejs#517 Reviewed-By: Seth Brenith <[email protected]>
The `Reg*` APIs on Windows don't use `GetLastError` to report failures. The errors are returned directly from the call. For systems which don't have one of the values `GetLastError` can end up returning `0` to the caller, indicating success. The caller then assumes that the data is valid and can attempt to execute on garbage data. This change fixes the flow to correctly return the error to the caller. Upstream-PR: libuv/libuv#1811 PR-URL: nodejs#517 Reviewed-By: Seth Brenith <[email protected]>
PR-URL: nodejs#517 Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
that referenced
this pull request
Apr 22, 2018
The `Reg*` APIs on Windows don't use `GetLastError` to report failures. The errors are returned directly from the call. For systems which don't have one of the values `GetLastError` can end up returning `0` to the caller, indicating success. The caller then assumes that the data is valid and can attempt to execute on garbage data. This change fixes the flow to correctly return the error to the caller. Upstream-PR: libuv/libuv#1811 PR-URL: #517 Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
that referenced
this pull request
Apr 22, 2018
PR-URL: #517 Reviewed-By: Seth Brenith <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Reg*APIs on Windows don't useGetLastErrorto report failures.The errors are returned directly from the call.
For systems which don't have one of the values
GetLastErrorcan endup returning
0to the caller, indicating success. The caller thenassumes that the data is valid and can attempt to execute on garbage
data. This change fixes the flow to correctly return the error to the
caller.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes